From 1cae4fc91f098d37437a3e1dd6384df5b83911fd Mon Sep 17 00:00:00 2001 From: Shrikant Sharat Date: Wed, 18 Jul 2012 21:58:31 +0530 Subject: [PATCH] Some refactoring and more tests to url resolver. --- antigen.zsh | 4 ++-- tests/url-resolver.t | 9 +++++++++ 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/antigen.zsh b/antigen.zsh index 096abbe..e289761 100644 --- a/antigen.zsh +++ b/antigen.zsh @@ -69,13 +69,13 @@ antigen-bundle () { local url="$1" + # Expand short github url syntax: `username/reponame` if [[ $url != git://* && \ $url != https://* && \ $url != /* && \ $url != git@github.com:*/* ]]; then - url="${url%.git}" - url="https://github.com/$url.git" + url="https://github.com/${url%.git}.git" fi echo "$url" diff --git a/tests/url-resolver.t b/tests/url-resolver.t index fc34bfe..a4f4436 100644 --- a/tests/url-resolver.t +++ b/tests/url-resolver.t @@ -11,6 +11,15 @@ Complete urls. $ resolve git@github.com:zsh-users/antigen.git git@github.com:zsh-users/antigen.git +Complete github urls, missing the `.git` suffix. + + $ resolve https://github.com/zsh-users/antigen + https://github.com/zsh-users/antigen + $ resolve git://github.com/zsh-users/antigen + git://github.com/zsh-users/antigen + $ resolve git@github.com:zsh-users/antigen + git@github.com:zsh-users/antigen + Just username and repo name. $ resolve zsh-users/antigen -- 2.0.0